[5.3] Send multipart email notification #15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
|
I would go with the non-breaking change method. |
tillkruss
force-pushed
the
text-emails
branch
2 times, most recently
from
be4cd4b
to
bf4d338
Compare
|
Done.
|
|
Thanks. Can you send a docs PR? |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if Laravel would send a plain text alternative alongside the HTML email notifications out of the box. Reasons for that are:
Since calling
php artisan vendor:publishis necessary anyhow to add the new plain text template file, I also went ahead and changed theresourcedirectory structure from:To:
If that's too much of a breaking change, we could do this:
Feedback appreciated 😀